mbien commented on PR #8455: URL: https://github.com/apache/netbeans/pull/8455#issuecomment-2831101617
> That OptionsUtils class should probably protect the caching map for concurrent access? it stores it in fields, but those should be volatile at the very least, yeah. I won't change anything unless it also fixes the problem completely, since changing the timing could only obfuscate the issue. > Maybe there should be method in OptionsUtils to flush its cache instead? Or even set keys through it. It's not API anyway as far as I can see. this wouldn't be sufficient. Since nothing knows what is still in the event queue at this point. I observed the clear event arriving after the Preference write but before the write event arrived. The "happens before" promise doesn't exist if the event thread itself can't be flushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
