neilcsmith-net commented on PR #8455: URL: https://github.com/apache/netbeans/pull/8455#issuecomment-2831405201
> > That OptionsUtils class should probably protect the caching map for concurrent access? > > it stores it in fields, but those should be volatile at the very least, yeah. hmmm, I totally misread where the storage was at a glance! 😆 But yes, possibly volatile ... > > Maybe there should be method in OptionsUtils to flush its cache instead? Or even set keys through it. It's not API anyway as far as I can see. > > this wouldn't be sufficient. Since nothing knows what is still in the event queue at this point. I was only thinking of the test requirements, not a general fix. Enough to ensure the setting in the test works synchronously. Another option might be to add a temporary second preference listener (assuming they're called in the order they're added) and listen for the required event(s) to propagate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
