Achal1607 commented on code in PR #8460:
URL: https://github.com/apache/netbeans/pull/8460#discussion_r2062908392
##########
java/maven.hints/src/org/netbeans/modules/maven/hints/pom/MavenPOMParser.java:
##########
@@ -76,13 +78,17 @@ public void parse(Snapshot snapshot, Task task,
SourceModificationEvent event) t
return;
}
//#236116 passing document protects from looking it up later and
causing a deadlock.
- final BaseDocument document =
(BaseDocument)snapshot.getSource().getDocument(false);
+ final Document doc = snapshot.getSource().getDocument(false);
final DataObject d = sFile.getLookup().lookup(DataObject.class);
+ try {
+ final BaseDocument document = Utilities.asBaseDocument(doc, d);
ModelSource ms = Utilities.createModelSource(sFile, d, document);
synchronized (this) {
theModel = POMModelFactory.getDefault().getModel(ms);
lastSnapshot = snapshot;
}
+ } catch (IOException ignored) {
+ }
Review Comment:
Okay thanks @mbien, did the needful change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
