lahodaj commented on PR #8460: URL: https://github.com/apache/netbeans/pull/8460#issuecomment-2850200019
The comment on line 79 talks about a possible deadlock, referring to this issue: https://bz.apache.org/netbeans/show_bug.cgi?id=236116 It is not completely clear if the deadlock can still happen. But some care is probably needed here. I wonder if the requirement for `BaseDocument` still applies - what would break if simply an ordinary `Document` would be used to create the `ModelSource`? Alternatively, if the `BaseDocument` is really needed by the users of `ModelSource`, maybe the `Document` can be wrapped to `BaseDocument` in `Utilities.createModelSource` around line 187 using the approach from `Utilities.getDocument`? (Although the code to create the `BaseDocument` out of thin air in `Utilities.getDocument` seems dubious to me.) Possibly factor the `BaseDocument` creation out of the `getDocument` method, or something like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
