stoty commented on PR #8725: URL: https://github.com/apache/netbeans/pull/8725#issuecomment-3197812479
> I'm in two minds whether this is a good move. NetBeans and the platform have not been `JAVA_HOME` aware by default in the past, which might make this an unexpected change. On the other hand, it brings it in line with recent changes in the Windows launcher. Of course, that was broken before so not quite the same thing! I saw JDK_HOME being used, that was probably the VisualVM Windows launcher code, not the NetBeans one. > > We should probably ignore `JDK_HOME` to keep in line with the new Windows launcher behaviour? Sure, will remove. > > The [NBPackage script](https://github.com/apache/netbeans-nbpackage/blob/master/src/main/resources/org/apache/netbeans/nbpackage/deb/deb.launcher.template) sets `JAVA_HOME` for the DEB and RPM packages, although there shouldn't be any effect here if this is ignored with `jdkhome` set. I think there's a reverse to consider here too - whether `JAVA_HOME` should then always be set to the `jdkhome` value for the execution of the IDE / platform application? I don't think that's really necessary. The only time JAVA_HOME would come up is when NetBeans is starting a new JDK, If it is started directly case NB would use one of the configured JDK instances. In the indirect case (i.e. NB starts a shell script or C code which starts a JDK) it may be sometimes useful, but IMO it's better to be transparent and not try to second guess the user's evironment setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
