neilcsmith-net commented on PR #8725:
URL: https://github.com/apache/netbeans/pull/8725#issuecomment-3200156634

   > I saw JDK_HOME being used, that was probably the VisualVM Windows launcher 
code, not the NetBeans one.
   
   Maybe.  I don't know why they use a fork of that but not this.
   
   > > I think there's a reverse to consider here too - whether `JAVA_HOME` 
should then always be set to the `jdkhome` value for the execution of the IDE / 
platform application?
   > 
   > I don't think that's really necessary.
   > 
   > The only time JAVA_HOME would come up is when NetBeans is starting a new 
JDK,
   
   Just a related thought to this.  It's set conservatively when unset by the 
user in the DEB and RPM.  I find it very useful to ensure that the terminal, 
etc. in the IDE has JAVA_HOME set to the JDK the IDE is running on.
   
   Thanks for the changes.  Let's see if anyone else has any comments, and that 
@matthiasblaesing issue is resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to