neilcsmith-net commented on code in PR #112:
URL:
https://github.com/apache/netbeans-nbpackage/pull/112#discussion_r2310155385
##########
src/main/java/org/apache/netbeans/nbpackage/FileUtils.java:
##########
@@ -263,7 +262,7 @@ public static List<Path> findDirs(Path searchDir, int
searchDepth, String... pat
}
}).allMatch(v -> v);
})) {
- return List.copyOf(stream.collect(Collectors.toList()));
+ return List.copyOf(stream.toList());
Review Comment:
I'm not sure (other than by mistake) why only one of those methods returned
an unmodifiable list. I think both should be the same, and probably
`stream.toList()` is the right option now. Possibly add note to docs that
mentions the return is unmodifiable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
