neilcsmith-net commented on code in PR #112:
URL:
https://github.com/apache/netbeans-nbpackage/pull/112#discussion_r2310899512
##########
src/main/java/org/apache/netbeans/nbpackage/FileUtils.java:
##########
@@ -263,7 +262,7 @@ public static List<Path> findDirs(Path searchDir, int
searchDepth, String... pat
}
}).allMatch(v -> v);
})) {
- return List.copyOf(stream.collect(Collectors.toList()));
+ return List.copyOf(stream.toList());
Review Comment:
Yes, and the point was `Path::of` is completely interchangeable, whereas
this is a behavioural difference. But looks fine. Just more to review! 😄
Please remove the now superfluous wrapping in `List::copyOf` which is main
reason I commented here.
As I said, `ArchiveUtils` was deliberately left package private and mostly
untouched. Changing `replaceAll` would be good at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org
For additional commands, e-mail: notifications-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
