matthiasblaesing commented on code in PR #8790: URL: https://github.com/apache/netbeans/pull/8790#discussion_r2328319602
########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/filter_effects.properties: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# CSS Box Alignment Module Review Comment: This comment makes no sense - copy and paste artifact? ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/filter_effects.properties: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# CSS Box Alignment Module + +$category=filter_effects + +backdrop-filter = <filter-value-list> Review Comment: This is missing `none` and most probably `<var-fn>` here and as an element of `@filter-value-list`. The parameters of the filter functions are covered by their base definitions, but in the list and the property itself I'd assume that `var` is fair game. ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/image_values.properties: ########## @@ -56,6 +56,12 @@ $category=images <color-stop> [ , <color-stop>]+ \ ) +@conic-gradient = conic-gradient ( <angular-color> [, <angular-color> ]* ) + +@angular-color = [ <color> [<angle-percentage>{1,2}]? ] | [ from <angle-percentage> [ at [ <bg-pos> ]{1,2} ]? ] Review Comment: I think this is missing `<var-fn>` as alternative ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/overflow.properties: ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# CSS Box Alignment Module + +$category=overflow + +scroll-behavior = auto | smooth + +scroll-margin = <scroll-numeric-values>{1,4} +scroll-padding = <scroll-numeric-values>{1,4} Review Comment: These are short hands. Would it make sense to directly add the individual definitions? (I mean `scroll-margin-top`, `scroll-margin-bottom`, ...` ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/overflow.properties: ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# CSS Box Alignment Module Review Comment: Copy and paste artifact ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/overflow.properties: ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# CSS Box Alignment Module + +$category=overflow + +scroll-behavior = auto | smooth + +scroll-margin = <scroll-numeric-values>{1,4} +scroll-padding = <scroll-numeric-values>{1,4} + +@scroll-numeric-values=<length> | <percentage> | auto Review Comment: This is only correct for `scroll-padding`, `scroll-margin` is a pure length. (`var-fn` is covered here by `<length>` and `<percentage>`). ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/backgrounds_and_borders.properties: ########## @@ -29,8 +29,9 @@ background-clip=[<bg-box> [ , <bg-box> ]*] background-color=<color> -background-image=[<bg-image> [ , <bg-image> ]*] +background-image=[<bg-image> [ , <bg-image> ]*] | <gradients> +@gradients=[ <gradient> [ , <gradient>]? ] Review Comment: `<gradients>` should not be needed here. `bg-image` can be `<image>` and `<image>` can be `<gradient>`. So `<gradients>` is already covered by `background-image` . ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/filter_effects.properties: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# CSS Box Alignment Module + +$category=filter_effects + +backdrop-filter = <filter-value-list> + +@filter-value-list = [<filter-function> | <url>]+ + +@filter-function = <blur> | <brightness> | <contrast> | <drop-shadow> | \ + <grayscale> | <hue-rotate> | <invert> | <opacity> | <sepia> | <saturate> +@blur = blur ( <length> ) +@brightness = brightness ( <length> | <percentage> ) +@contrast = contrast ( <length> | <percentage> ) +@drop-shadow = drop-shadow ( <color> && <length>{2,3} ) +@grayscale = grayscale ( <length> | <percentage> ) +@hue-rotate = hue-rotate ( <angle> ) +@invert = invert ( <length> | <percentage> ) +@opacity = opacity ( <length> | <percentage> ) +@sepia = sepia ( <length> | <percentage> ) +@saturate = saturate ( <length> | <percentage> ) + +@url = url ( !string | !identifier ) Review Comment: I suggest to use `uri` here (see `default_module.properties` line 23 and the grammar file). ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/backgrounds_and_borders.properties: ########## @@ -60,7 +61,7 @@ background-size=[ <bg-size> [ , <bg-size> ]* ] @bg-size= [ <length> | <percentage> | auto ]($pair){1,2} | [ cover | contain ]($single) -background=[ [ <bg-layer> , ]* <final-bg-layer> ] +background=[ [ <bg-layer> , ]* <final-bg-layer> ] | <gradient> Review Comment: Same as with `background-image`, no need to change this. ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/image_values.properties: ########## @@ -56,6 +56,12 @@ $category=images <color-stop> [ , <color-stop>]+ \ ) +@conic-gradient = conic-gradient ( <angular-color> [, <angular-color> ]* ) + +@angular-color = [ <color> [<angle-percentage>{1,2}]? ] | [ from <angle-percentage> [ at [ <bg-pos> ]{1,2} ]? ] + +@angle-percentage = <angle> | <percentage> Review Comment: And `<var-fn>` also missing here. ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/overflow.properties: ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# CSS Box Alignment Module + +$category=overflow + +scroll-behavior = auto | smooth Review Comment: or `<var-fn>` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@netbeans.apache.org For additional commands, e-mail: notifications-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
