matthiasblaesing commented on code in PR #8790: URL: https://github.com/apache/netbeans/pull/8790#discussion_r2356642818
########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/scroll_snap.properties: ########## @@ -0,0 +1,23 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# CSS Scroll Snap Module + +$category=overflow Review Comment: Copy and Paste bug? ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/DefaultCssEditorModule.java: ########## @@ -88,6 +88,7 @@ public class DefaultCssEditorModule extends CssEditorModule { module("text", "http://www.w3.org/TR/css-text-4";), //NOI18N module("writing_modes", "http://www.w3.org/TR/css3-writing-modes";), //NOI18N module("generated_content_for_paged_media", "http://www.w3.org/TR/css3-gcpm";), //NOI18N + module("filter_effects", "https://www.w3.org/TR/filter-effects-1/";), //NOI18N Review Comment: The URLs need to keep the same base URL. See `org.netbeans.modules.css.editor.module.main.StandardPropertiesHelpResolver` for the extraction logic. ```suggestion module("filter_effects", "http://www.w3.org/TR/filter-effects-1";), //NOI18N ``` ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/DefaultCssEditorModule.java: ########## @@ -105,6 +106,8 @@ public class DefaultCssEditorModule extends CssEditorModule { module("alignment", "http://www.w3.org/TR/css-align-3";), //NOI18N module("fragmentation", "http://www.w3.org/TR/css-break-3";), //NOI18N module("positioning", "http://www.w3.org/TR/css-position-3";), //NOI18N + module("overflow", "https://www.w3.org/TR/css-overflow-3/";), //NOI18N + module("scroll_snap", "https://drafts.csswg.org/css-scroll-snap/";), //NOI18N Review Comment: ```suggestion module("scroll_snap", "http://www.w3.org/TR/css-scroll-snap-1";), //NOI18N ``` ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/overflow.properties: ########## @@ -0,0 +1,44 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# CSS Box Overflow Module + +$category=overflow + +scroll-behavior = auto | smooth | <var-fn> + +scroll-margin = <scroll-margin-value>{1,4} +scroll-padding = <scroll-padding-value>{1,4} + +scroll-margin-block = <scroll-margin-value>{1,2} +scroll-padding-block = <scroll-padding-value>{1,2} + +scroll-margin-inline = <scroll-margin-value>{1,2} +scroll-padding-inline = <scroll-padding-value>{1,2} + +scroll-margin-top = <scroll-margin-value> +scroll-margin-bottom = <scroll-margin-value> +scroll-margin-left = <scroll-margin-value> +scroll-margin-right = <scroll-margin-value> + +scroll-padding-top = <scroll-padding-value> +scroll-padding-bottom = <scroll-padding-value> +scroll-padding-left = <scroll-padding-value> +scroll-padding-right =<scroll-padding-value> + +@scroll-margin-value = <length> +@scroll-padding-value = <length-percentage> | auto Review Comment: These need to be moved to `scroll_snap.properties`. These are not properties in the "CSS Overflow" module, but the "CSS Scroll Snap" module. ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/DefaultCssEditorModule.java: ########## @@ -105,6 +106,8 @@ public class DefaultCssEditorModule extends CssEditorModule { module("alignment", "http://www.w3.org/TR/css-align-3";), //NOI18N module("fragmentation", "http://www.w3.org/TR/css-break-3";), //NOI18N module("positioning", "http://www.w3.org/TR/css-position-3";), //NOI18N + module("overflow", "https://www.w3.org/TR/css-overflow-3/";), //NOI18N Review Comment: ```suggestion module("overflow", "http://www.w3.org/TR/css-overflow-3";), //NOI18N ``` ########## ide/css.editor/src/org/netbeans/modules/css/editor/module/main/properties/basic_box_model.properties: ########## Review Comment: Please move the new properties defined here to their own properties files (I suggest `logical.properties`) as they are not defined by the basic box model, but by "CSS Logical Properties and values". The module should be defined with the URL `http://www.w3.org/TR/css-logical-1`. The modules defined in `DefaultCssEditorModule` correspond to the specifications from the W3C and follow their organisation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
