lahodaj commented on PR #8968: URL: https://github.com/apache/netbeans/pull/8968#issuecomment-3481972691
Overall +1 on reporting the warnings to the user. But, please: - there's a lot of code duplication in each refactoring class that handles the warnings, etc. Is there a chance that would be factored out into `CodeRefactoring`? Maybe it would also allow to reduce churn in that class? - in `java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/refactoring/MoveRefactoring.java`, it seems there's a huge amount of changes, which are probably mostly formatting(?) - I would suggest to undo that, it makes it very hard to review that part of the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
