lahodaj commented on PR #8968: URL: https://github.com/apache/netbeans/pull/8968#issuecomment-3502663653
Functionally seems OK to me. There are some formatting/cleanup that I would suggest to do, shown here: https://github.com/shivam71/netbeans/pull/1 (reducing access, removing stuff no longer needed, keeping spaces consistent with the file). If I was writing this, I would probably inline `CodeRefactoring.warningsMessageParams` and `CodeRefactoring.prepare` into their callers, but I don't think that is strictly necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
