neilcsmith-net commented on PR #8959: URL: https://github.com/apache/netbeans/pull/8959#issuecomment-3506552739
> > Please confirm / ensure we have behaviour compatibility in the platform Unix script before this merges. > > * how do you want that to be ensured? > > * I am convinced the Unix scripts and Windows launchers behave the same Ah, I missed you'd updated your original comment and added a commit reference to opt out the platform launcher in https://github.com/apache/netbeans/pull/8756#issuecomment-3388564175 I was looking for changes in the Unix platform launcher as I've been out of the NB loop for a few weeks. I remain in favour, as in the comment below that, of having the platform and IDE launchers aligned. But, I'll remove the request for changes here as it seems to be inaccurate. Apologies for that. > > I think that the points raised by @matthiasblaesing > * points raised by Matthias were probably addressed as documented > > * by this [comment](https://github.com/apache/netbeans/pull/8756#issuecomment-3452292129) claiming my changes _"look safe enough"_ That's an interesting way of assuming approval given it also states a preference to fix the existing approach. A view which is shared. > Please approve the integration. Request for changes removed, but I'm not approving. By my calculation these changes are currently about -2.7 (3x -0.9) on the approval scale. Let's test, and let's also see why fixing `ideopen` is not the right approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
