mbien commented on PR #8959: URL: https://github.com/apache/netbeans/pull/8959#issuecomment-3506747815
> No, we're in post-merge approval mode! We don't have a formal pre-merge approval mode in line with ASF's definition of review-then-commit. I don't feel to drag this into off topic but since I got pinged again I suppose i can share that the merge history shows that all noteworthy PRs are reviewed before merge, usually indicated by other committers approving them - there are only few exceptions which probably is ok. We absolutely have the ability to recheck and revert changes post merge, but it certainly is not the rule and it is something we should try to avoid for our own sanity. (we had a fairly low revert count recently which is great!) I want you just to imagine for a moment a repo of the size of this one here, with 80 committers and no QA team and post merge approval _actually_ practiced. Pre-release would be a full time job of reverts, and within a year nobody would know anymore what is in the repo. Luckily, this is not how most PRs are merged. They are peer reviewed before merge. We even have some limited CI checks and a review guide which organically grew over time (changes to the guide were also discussed before they were made) to avoid to repeat merge accidents, have a stable master and try to reduce the amount of followup PRs. (merge accidents specifically are something which can't be reverted without force push since those are usually about _how_ it got merged not that it got merged) So please, just because each of us have the _ability_ to revert something post-merge, lets not pretend that post-merge approval or review is actually the _practiced_ mode, since it does not reflect reality. Again: most relevant PRs are reviewed, check the merge log. My suggestion is to simply change the phrasing from "we are running in commit then review mode" to "we can also review/revert post-merge if necessary". (I won't revert this change - don't worry, `NETBEANS_USERDIR=IGNORE` is already in my bash profile) Let us go around and help get good PRs in by reviewing them, instead of repeatedly pointing out that anything can be reverted since when using lawyer speak we theoretically review changes post merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
