haidubogdan opened a new pull request, #9113: URL: https://github.com/apache/netbeans/pull/9113
Part of issue #9034 - include Php 8.5 version option **Pipe Operator** For the pipe operator I've used a similar approach to the infix expression and based on this rfc : https://wiki.php.net/rfc/function-composition I've created a new AstNode CompositionExpression (Maybe it should be FunctionCompostionExpression ?). Trying to identify what is a variable or what is not a callable seemed to be very hard as you can assign a callable to a variable. Also, it's a chain type expression, so no clear syntax delimiters to included it as a stand alone ast rule. For the error syntax I've used a hint verification approach of identifying what type of expression is the right handle of a Composition Expression. The basic types of numeric tokens or boolean values can be marked directly as errors. In some future implementation we can add checks on callable types, as they require to take only one parameter (first-class-callables) . https://wiki.php.net/rfc/pipe-operator-v3#callable_styles - syntax support for pipe operator - hint for basic non-callable pipe operator right handle : integer, float, bool, infix expression - formatting adaptation - unit tests for lexer, parser, hint verification Todo | work in progress (while review is in progress :) ) - [ ] unit test for formatting --- **^Add meaningful description above** <details open> <summary>Click to collapse/expand PR instructions</summary> By opening a pull request you confirm that, unless explicitly stated otherwise, the changes - - are all your own work, and you have the right to contribute them. - are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information). Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field. If you're a first time contributor, see the Contributing guidelines for more information. If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run. ### PR approval and merge checklist: 1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run? 2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)? 3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates? 3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes? If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide)) </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
