tmysik commented on code in PR #9113:
URL: https://github.com/apache/netbeans/pull/9113#discussion_r2878304527
##########
php/php.api.phpmodule/src/org/netbeans/modules/php/api/PhpVersion.java:
##########
@@ -41,6 +41,7 @@
"PhpVersion.PHP_82=PHP 8.2",
"PhpVersion.PHP_83=PHP 8.3",
"PhpVersion.PHP_84=PHP 8.4",
+ "PhpVersion.PHP_85=PHP 8.5",
Review Comment:
> bumped the version to 2.106.
Where? I don't see it. The version of `php.api.phpmodule` module has to be
increased (and all its usages using this new constant must be updated).
##########
php/php.api.phpmodule/src/org/netbeans/modules/php/api/PhpVersion.java:
##########
@@ -115,6 +116,11 @@ public enum PhpVersion {
* @since 2.100
*/
PHP_84(Bundle.PhpVersion_PHP_84()),
+ /**
+ * PHP 8.5
+ * @since 2.x
Review Comment:
```suggestion
* @since 2.106
```
##########
php/php.api.phpmodule/src/org/netbeans/modules/php/api/PhpVersion.java:
##########
@@ -41,6 +41,7 @@
"PhpVersion.PHP_82=PHP 8.2",
"PhpVersion.PHP_83=PHP 8.3",
"PhpVersion.PHP_84=PHP 8.4",
+ "PhpVersion.PHP_85=PHP 8.5",
Review Comment:
Sorry, my bad, now I see it 🙈
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
