mbien commented on PR #9241: URL: https://github.com/apache/netbeans/pull/9241#issuecomment-3985826928
> What else do you envisage this module possibly being used for too? there is a good chance that this module won't grow because this trick does only work if the surface of the covered API is tiny and the fallback is simple enough. We could rename it and make it less generic - I wasn't sure either. Maybe something else will show up? > My inclination would be towards putting this in openide.util. We're at least 4 years from being able to adopt solely use of the JDK API The general idea is to remove the indirection (in this case the module) once no longer needed and replace usage with the JDK api (would be very simple search/replace). I am not sure if it is possible to export a single package only for friends while having also normal public API (openide.util) - thats why I put it into a separate module instead of an existing one. > _potentially_ making it in to the JDK JDK itself uses the feature already for quite a while in form of the `@Stable` annotation. The fact that its API isn't finalized is another reason of keeping it internal since it would give us more options to course correct. I don't think that everything we use should also be public. `org.openide.util.WeakSet` should have been internal use only too IMO. It is always difficult to remove public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
