neilcsmith-net commented on PR #9241:
URL: https://github.com/apache/netbeans/pull/9241#issuecomment-3992674215

   > This is the reason why I try to add this in the first place. Maybe I am 
missing something, but why would this be more difficult to achieve as internal 
utility? Module adds itself on the friends list and uses it.
   
   Well, you've already added one extra unnecessary step! :wink: 
   
   Basically, I disagree with the use of friend modules to hide APIs all over 
the code base.  The friend feature should be used to provide a tunnel between 
interrelated modules that have a need to enable differently.  Other than that 
it's almost always been a mistake.
   
   Yes, we might deprecate this in 4 years.  It won't be less than 4.  And it 
might be that we have a reason to keep it as a wrapper even then.
   
   I'm not going to block this, but I think the fallback module aspect is just 
unnecessary extra complexity for a simple, useful feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to