matthiasblaesing commented on code in PR #9177: URL: https://github.com/apache/netbeans/pull/9177#discussion_r2879946072
########## enterprise/web.el/src/org/netbeans/modules/web/el/completion/ELCompletionUtil.java: ########## Review Comment: Nitpick: I don't understand the intention of this file. There are three callpaths that invoke the `ELResourceBundleKeyCompletionItem` constructor. Two invoke the constructor directly (in `ELCodeCompletionHandler`) and the new one takes this indirection. I would inline and be done with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
