mbien commented on code in PR #9307:
URL: https://github.com/apache/netbeans/pull/9307#discussion_r3043029981
##########
platform/core.startup/src/org/netbeans/core/startup/ModuleList.java:
##########
@@ -661,14 +680,23 @@ public void cacheReady() {
@Override
public void flushCaches(DataOutputStream os) throws IOException {
- ObjectOutputStream oss = new ObjectOutputStream(os);
for (Module m : mgr.getModules()) {
if (m.isFixed()) {
continue;
}
- Map<String, Object> prop = computeProperties(m);
- writeStatus(prop, oss);
- oss.writeObject(m.getDependencies());
+ // props
+ String list = computeProperties(m).entrySet()
+ .stream()
+ .map(e -> e.getKey() + "=" + e.getValue())
+ .collect(Collectors.joining(","));
Review Comment:
i will try to come up with something better. Part of the reason I remained
at the String level is convenience and simplicity. But if we can't do that due
to the separator issue, we could indeed go one level lower which would also
allow us to map all booleans to a single byte and write the two strings without
keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
