neilcsmith-net commented on code in PR #9307:
URL: https://github.com/apache/netbeans/pull/9307#discussion_r3044257319
##########
platform/openide.modules/src/org/openide/modules/Dependency.java:
##########
@@ -361,6 +365,39 @@ public static Set<Dependency> create(int type, String
body) throws IllegalArgume
return deps;
}
+ /**
Review Comment:
Yes, agreed. Is there any usage here where we read / write across IDE
versions? If not, I'd be more explicit that the format is only intended to be
read by the same version of `openide.modules`. Could possibly even enforce
that incompatibility with an extra header derived from the spec version
(perhaps with magic number) somehow?
Glad to see use of `DataInput` and `DataOutput` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
