mbien commented on code in PR #9414:
URL: https://github.com/apache/netbeans/pull/9414#discussion_r3325372377
##########
contrib/j2ee.weblogic9/nbproject/project.properties:
##########
@@ -17,7 +17,7 @@
# under the License.
#
-javac.source=1.8
+javac.source=11
Review Comment:
please switch to `javac.release`. plus: The NB project can use 21 now,
assuming tests pass.
feel free to edit the commit and force push
##########
contrib/j2ee.weblogic9/src/org/netbeans/modules/j2ee/weblogic9/deploy/WLJpa2SwitchSupport.java:
##########
@@ -397,7 +397,11 @@ private void createContributionsJar(File jarFile, String
classpath) throws IOExc
private void copy(File source, File dest) throws IOException {
try (InputStream is = new BufferedInputStream(new
FileInputStream(source));
OutputStream os = new BufferedOutputStream(new
FileOutputStream(dest))) {
- is.transferTo(os);
+ byte[] buf = new byte[4096];
+ int n;
+ while ((n = is.read(buf)) != -1) {
+ os.write(buf, 0, n);
+ }
Review Comment:
please revert too
##########
contrib/j2ee.weblogic9/src/org/netbeans/modules/j2ee/weblogic9/deploy/WLDriverDeployer.java:
##########
@@ -114,7 +114,11 @@ public void run() {
ActionType.EXECUTE,
CommandType.DISTRIBUTE, StateType.RUNNING,
NbBundle.getMessage(WLDriverDeployer.class, "MSG_DeployingJDBCDrivers",
toJar.getPath())));
try (BufferedOutputStream os = new
BufferedOutputStream(new FileOutputStream(toJar))) {
- is.transferTo(os);
+ byte[] buf = new byte[4096];
+ int n;
+ while ((n = is.read(buf)) != -1) {
+ os.write(buf, 0, n);
+ }
Review Comment:
unclear why this was changed. This does not appear to require jdk 8 target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
