mbien commented on code in PR #9414:
URL: https://github.com/apache/netbeans/pull/9414#discussion_r3424355144
##########
contrib/j2ee.weblogic9/src/org/netbeans/modules/j2ee/weblogic9/dd/model/BaseDescriptorModel.java:
##########
@@ -45,6 +45,8 @@ public class BaseDescriptorModel {
protected static final Version VERSION_12_1_1 =
Version.fromJsr277NotationWithFallback("12.1.1"); // NOI18N
protected static final Version VERSION_12_2_1 =
Version.fromJsr277NotationWithFallback("12.2.1"); // NOI18N
+
+ protected static final Version VERSION_14_1_1 =
Version.fromJsr277NotationWithFallback("14.1.1"); // NOI18N
Review Comment:
this doesn't appear to be used.
this indicates that either:
- the three generate methods in the model classes `EjbJarModel`,
`EarApplicationModel` and `WebApplicationModel` need to be updated
- or update is not needed and the constant can be removed if the emitted
code is OK for the version
##########
contrib/j2ee.weblogic9/src/org/netbeans/modules/j2ee/weblogic9/j2ee/WLJ2eePlatformFactory.java:
##########
@@ -130,6 +130,10 @@ public class WLJ2eePlatformFactory extends
J2eePlatformFactory {
private static final Version JDK8_SUPPORTED_SERVER_VERSION =
Version.fromJsr277NotationWithFallback("12.1.3"); // NOI18N
+ private static final Version JDK11_SUPPORTED_SERVER_VERSION =
Version.fromJsr277NotationWithFallback("14.1.1"); // NOI18N
+
+ private static final Version JDK17_SUPPORTED_SERVER_VERSION =
Version.fromJsr277NotationWithFallback("15.1.1"); // NOI18N
Review Comment:
seems to be correct
-
https://docs.oracle.com/en/middleware/standalone/weblogic-server/14.1.1.0/notes/whatsnew.html#GUID-960100E8-DFC1-49E5-8CED-1EC1D883A42F
-
https://docs.oracle.com/en/middleware/standalone/weblogic-server/15.1.1/notes/whatsnew.html#GUID-B6E42F6B-3C3C-4332-A064-DE14CD1A7E5C
but the versioning scheme is a bit wild, e.g it seems like 14.1.2 also
supports 17 and 21
-
https://docs.oracle.com/en/middleware/fusion-middleware/weblogic-server/14.1.2/notes/whatsnew.html#GUID-DF8CFD1C-9DD1-423E-ACA6-9717D5738385
might not be super important though, worst case is that JDK 11 will show up
on a lower version in the combo box I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
