[
https://issues.apache.org/jira/browse/OFBIZ-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432278#comment-15432278
]
Jacopo Cappellato commented on OFBIZ-7016:
------------------------------------------
[~pfm.smits] I have reviewed your patch and I have identified some issues:
# the data in the patch seems to come from the ecommerce component but also
from other components (e.g. accounting); however your comment above refers to
the "party demo data in the ecommerce component" only; more importantly, in the
patch the removed files/data are not included making it difficult to assess the
origin of this data
# your patch seems to be based in a local copy containing non official
modifications, making it not valid for inclusion in the official OFBiz trunk
and not useful to other adopters/users willing to test or use it; see for
example the presence of the PartyRole.fromDate field; my recommendation to you
as a contributors is to always test the contributions and prepare your patches
on a pristine and update version of the trunk (or the branch you are willing to
contribute to)
# it would be useful to reviewers if you could specify in a comment the nature
and amount of tests that you have performed on your contribution
Thanks
Jacopo
> move base component demo data from specialpurpose/ecommerce to base components
> ------------------------------------------------------------------------------
>
> Key: OFBIZ-7016
> URL: https://issues.apache.org/jira/browse/OFBIZ-7016
> Project: OFBiz
> Issue Type: Sub-task
> Components: specialpurpose/ecommerce
> Affects Versions: Trunk
> Reporter: Pierre Smits
> Attachments: OFBIZ-7016-EcommercePartyData.patch,
> OFBIZ-7016-EcommerceProductData.patch, demo_marketing_moved.patch
>
>
> Currently a lot of demo data exists in the ecommerce component that should go
> into the appropriate base components (e.g. party, product, etc)...
> If a adopting organisation wants to assess OFBiz without the components in
> special purpose (which should be possible), loading of the demo data of sec
> the base components fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
