[ https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15477916#comment-15477916 ]
Taher Alkhateeb commented on OFBIZ-8179: ---------------------------------------- Hi Jacopo, Great work! Why comment out the transaction-factory and not delete instead? Or do you want to do that in one shot while deleting the geronimo component and libs from build.gradle as well (which would be great I might add) > Enhance DBCPConnectionFactory to implement a TransactionFactory and remove > the geronimo component > ------------------------------------------------------------------------------------------------- > > Key: OFBIZ-8179 > URL: https://issues.apache.org/jira/browse/OFBIZ-8179 > Project: OFBiz > Issue Type: Improvement > Components: framework > Affects Versions: Trunk > Reporter: Jacopo Cappellato > Assignee: Jacopo Cappellato > Priority: Minor > Attachments: OFBIZ-8179.patch, > TransactionConnectionFactory-before-after.png > > > Made the DBCPConnectionFactory an implementation of TransactionFactory by > moving the code from the GeronimoTransactionFactory. > With this change the geronimo component is no more required. > Without any functional change, this design simplifies greatly the calls and > component dependencies because it removes a cyclic dependency between entity > and geronimo components (see diagram attached that explain the architecture > before and after this change). -- This message was sent by Atlassian JIRA (v6.3.4#6332)