[
https://issues.apache.org/jira/browse/OFBIZ-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15479392#comment-15479392
]
Jacopo Cappellato commented on OFBIZ-8179:
------------------------------------------
[~taher] I think you are referring to:
{code}
<!-- the connection factory class to use, one is needed for obtaining
connections/pools for defined resources -->
+ <!--
<connection-factory
class="org.apache.ofbiz.entity.connection.DBCPConnectionFactory"/>
+ -->
{code}
I have commented it out because it is not required setting and it is not
specifically required by the new transaction-factory.
I agree with you that it is better to remove it rather than leaving it
commented out.
Thanks
> Enhance DBCPConnectionFactory to implement a TransactionFactory and remove
> the geronimo component
> -------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-8179
> URL: https://issues.apache.org/jira/browse/OFBIZ-8179
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: Trunk
> Reporter: Jacopo Cappellato
> Assignee: Jacopo Cappellato
> Priority: Minor
> Attachments: OFBIZ-8179.patch,
> TransactionConnectionFactory-before-after.png
>
>
> Made the DBCPConnectionFactory an implementation of TransactionFactory by
> moving the code from the GeronimoTransactionFactory.
> With this change the geronimo component is no more required.
> Without any functional change, this design simplifies greatly the calls and
> component dependencies because it removes a cyclic dependency between entity
> and geronimo components (see diagram attached that explain the architecture
> before and after this change).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
