[
https://issues.apache.org/jira/browse/OFBIZ-10195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366703#comment-16366703
]
Taher Alkhateeb commented on OFBIZ-10195:
-----------------------------------------
After a first review of the patch, I really like it, well done Gil!
Looking at the code, the whole logic needs refactoring, but we should do this
after you implement this feature. The current design forced you to copy paste
the same logic in many different places – bad original design – but that's not
your fault.
I will try to test this feature, but I like everything in the patch so far.
Well documented, well formatted and comprehensive. Thumbs up for the quality
work Gil
> Add the ability in performFind service to set OR search criteria
> ----------------------------------------------------------------
>
> Key: OFBIZ-10195
> URL: https://issues.apache.org/jira/browse/OFBIZ-10195
> Project: OFBiz
> Issue Type: Improvement
> Reporter: Gil Portenseigne
> Assignee: Gil Portenseigne
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch
>
>
> When using performFind service for advanced entity search, we can meet the
> need to have search criteria that do not intersect between them, but make the
> union of the condition.
> To realize this improvement we propose to set a new suffix _grp.
> Thus using :
> <field name="field1"><text-find/></field>
> <field name="field1_grp"><hidden value="unionKey"/></field>
> <field name="field2"><text-find/></field>
> <field name="field2_grp"><hidden value="unionKey"/></field>
> Then the two search fields criteria will be unioned during the search by the
> OR operator.
> Several different keys can be used for several different unioned condition.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
