Taher Alkhateeb commented on OFBIZ-10195:

Hi Gil,

I see, now I understand your point. I thought about this a little bit and I 
think your point about having search-only fields impacted makes good sense. 
However, if I was to choose between the two options, I think maybe I would 
prefer to stick the condition-group attribute to the field directly. The 
reasons for my preference are:
 * First as you indicated, less copy-paste, hence less code maintenance.
 * It might be strange for users to understand what this condition-group 
attribute means and why it shows up in some fields but not other fields. This 
condition impacts the whole field regardless of its type (it applies to the 
field, not necessarily the details of the field).
 * When will you use this attribute? You will use it in a search form right? I 
find it unlikely that you will use non-search fields in a search form.
 * Take the bigger picture as an example ... some fields are not suitable for 
search forms, other fields are not suitable for display forms, yet all of them 
are available to all forms. In other words we have no specialized forms. By the 
same token I think perhaps we do not need specialized search fields.

Either way we decide to go, great work again ! I love the idea of what you're 

> Add the ability in performFind service to set OR search criteria
> ----------------------------------------------------------------
>                 Key: OFBIZ-10195
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10195
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Gil Portenseigne
>            Assignee: Gil Portenseigne
>            Priority: Minor
>             Fix For: Upcoming Branch
>         Attachments: OFBIZ-10195.patch, OFBIZ-10195.patch
> When using performFind service for advanced entity search, we can meet the 
> need to have search criteria that do not intersect between them, but make the 
> union of the condition.
> To realize this improvement we propose to set a new suffix _grp.
> Thus using :
> <field name="field1"><text-find/></field>
> <field name="field1_grp"><hidden value="unionKey"/></field>
> <field name="field2"><text-find/></field>
> <field name="field2_grp"><hidden value="unionKey"/></field>
> Then the two search fields criteria will be unioned during the search by the 
> OR operator.
> Several different keys can be used for several different unioned condition.

This message was sent by Atlassian JIRA

Reply via email to