[
https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673093#comment-16673093
]
Mathieu Lirzin commented on OFBIZ-10606:
----------------------------------------
I have included [^OFBIZ-10606_0001-Add-WebAppCache.patch] which extracts the
webapp cache related method into a dedicated class,
[^OFBIZ-10606_0002-Add-tests-for-WebAppCache.patch] which provides
characterization tests, [^OFBIZ-10606_0003-Refactor-WebAppCache.patch] which
improves the implementation by using a more declarative style, and
[^OFBIZ-10606_0004-Inline-getAppBarWebInfos-String-Comparator-String-pr.patch]
which removes an uneeded helper method. Those patches must be applied in order.
When commiting, please don't squash those patches, This would make it difficult
for people to understand what changed when reading the diff.
Thanks.
> Webapp related code should be extracted from ‘ComponentConfig’
> ---------------------------------------------------------------
>
> Key: OFBIZ-10606
> URL: https://issues.apache.org/jira/browse/OFBIZ-10606
> Project: OFBiz
> Issue Type: Improvement
> Components: base
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10606_0001-Add-WebAppCache.patch,
> OFBIZ-10606_0002-Add-tests-for-WebAppCache.patch,
> OFBIZ-10606_0003-Refactor-WebAppCache.patch,
> OFBIZ-10606_0004-Inline-getAppBarWebInfos-String-Comparator-String-pr.patch
>
>
> The {{ComponentConfig}} mixes various concerns which should be separated to
> make the code more understandable. The method touching the {{serverWebApps}}
> static member could be put in a separated class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
