[ https://issues.apache.org/jira/browse/OFBIZ-10606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678232#comment-16678232 ]
Mathieu Lirzin commented on OFBIZ-10606: ---------------------------------------- So it appears that "flatgrey", "tomahawk", and "bluelight" use {{LoginWorker#getAppBarWebInfos. However "rainbowstone" is basically reimplementing what is done by }}{{LoginWorker#getAppBarWebInfos}}{{ directly in the }}{{themes/rainbowstone/template/includes/TopAppBar.ftl}} Freemarker template.{{}} {{I am not familiar with how themes are supposed to work, but I would guess that the "rainbowstone" approach seems not desirable.}} > Webapp related code should be extracted from ‘ComponentConfig’ > --------------------------------------------------------------- > > Key: OFBIZ-10606 > URL: https://issues.apache.org/jira/browse/OFBIZ-10606 > Project: OFBiz > Issue Type: Improvement > Components: base > Affects Versions: Trunk > Reporter: Mathieu Lirzin > Assignee: Jacques Le Roux > Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-10606_0001-Add-WebAppCache.patch, > OFBIZ-10606_0001-Add-WebAppCache.patch, > OFBIZ-10606_0002-Add-tests-for-WebAppCache.patch, > OFBIZ-10606_0003-Refactor-WebAppCache.patch, > OFBIZ-10606_0004-Inline-getAppBarWebInfos-String-Comparator-String-pr.patch, > OFBIZ-10606_0005-Use-Optional-for-getWebappInfo.patch > > > The {{ComponentConfig}} mixes various concerns which should be separated to > make the code more understandable. The method touching the {{serverWebApps}} > static member could be put in a separated class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)