[
https://issues.apache.org/jira/browse/OFBIZ-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690456#comment-16690456
]
Taher Alkhateeb commented on OFBIZ-10638:
-----------------------------------------
Hello Mathieu, Thank you for your work so far, and my apology for not picking
this up earlier.
I was just reviewing patch 1, and I remember doing something similar in the
past but I think I got a problem around thread synchronization and access to
variables. Are you confident of your code in patch1? Did you apply initial
smoke tests? Are all the containers running okay? Did you investigate the
variable state for the container loader? Did you test multiple scenarios like
running data loading, running integration tests and all of that? Everything
okay?
Sorry for the too many questions, but this is critical code and so we should
tread carefully and slowly.
> The ‘StartupLoader’ interface should be removed
> -----------------------------------------------
>
> Key: OFBIZ-10638
> URL: https://issues.apache.org/jira/browse/OFBIZ-10638
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Taher Alkhateeb
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10638_0001-Remove-StartupLoader-interface.patch,
> OFBIZ-10638_0002-Remove-unnecessary-arguments-in-AdminServer.patch,
> OFBIZ-10638_0003-Refactor-StartupControlPanel.patch,
> OFBIZ-10638_0004-Refactor-ContainerLoader.patch
>
>
> OFBiz used to provide alternate Startup loaders. Nowadays only the container
> loaders is used. As suggested by Taher [on the dev mailing
> list|https://lists.apache.org/thread.html/f99d6f661eb8197df8eac6d8ba7db3fa9b7fe2569a4a24ef2fef5cae@%3Cdev.ofbiz.apache.org%3E],
> the {{StartupLoader}} interface should be removed and startup code using it
> should be adapted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
