[
https://issues.apache.org/jira/browse/OFBIZ-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16691489#comment-16691489
]
Mathieu Lirzin commented on OFBIZ-10638:
----------------------------------------
My understanding is that the synchronization mechanism I removed was only
present to ensure that the manipulation of the {{loaders}} list was done
atomically. It should not affect the loading/unloading of containers since
those operations are still done by synchronized methods in the
{{ContainerLoader}} class. The reason I removed the synchronized block is that
there is no list to manipulate anymore.
After installing all the birt plugin the birt container is loading, here is the
log:
{code}
2018-11-19 09:40:00,047 |main |ContainerLoader
|I| Starting container catalina-container
...
2018-11-19 09:40:07,835 |main |ContainerLoader
|I| Started container catalina-container
2018-11-19 09:40:07,835 |main |ContainerLoader
|I| Starting container birt-container
...
2018-11-19 09:40:09,229 |main |ContainerLoader
|I| Started container birt-container
{code}
> The ‘StartupLoader’ interface should be removed
> -----------------------------------------------
>
> Key: OFBIZ-10638
> URL: https://issues.apache.org/jira/browse/OFBIZ-10638
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: Trunk
> Reporter: Mathieu Lirzin
> Assignee: Taher Alkhateeb
> Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10638_0001-Remove-StartupLoader-interface.patch,
> OFBIZ-10638_0002-Remove-unnecessary-arguments-in-AdminServer.patch,
> OFBIZ-10638_0003-Refactor-StartupControlPanel.patch,
> OFBIZ-10638_0004-Refactor-ContainerLoader.patch
>
>
> OFBiz used to provide alternate Startup loaders. Nowadays only the container
> loaders is used. As suggested by Taher [on the dev mailing
> list|https://lists.apache.org/thread.html/f99d6f661eb8197df8eac6d8ba7db3fa9b7fe2569a4a24ef2fef5cae@%3Cdev.ofbiz.apache.org%3E],
> the {{StartupLoader}} interface should be removed and startup code using it
> should be adapted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
