[ https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858591#comment-16858591 ]
Swapnil M Mane commented on OFBIZ-10145: ---------------------------------------- Hi [~jacques.le.roux] , Thank you for your efforts. :) I see no harm in copying gradle-wrapper.jar and gradle-wrapper.properties from our repository. (let's see what others say) Based on your input, our updated script will look someting like this. {code:java} OFBIZ_HOME="$(pwd)" GRADLE_WRAPPER_OFBIZ_PATH="$OFBIZ_HOME/gradle/" WRAPPER_URL="http://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper/trunk/gradle-wrapper.jar" WRAPPER_PROPERTIES_URL="http://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper/trunk/gradle-wrapper.properties" whereIsBinary() { whereis $1 | grep / } if [ ! -d "$GRADLE_WRAPPER_OFBIZ_PATH" ]; then echo "Location seems to be incorrect, please run the 'sh gradle/init-gradle-wrapper.sh' script from Apache OFBiz root."; exit -1; fi if [ -n "$(whereIsBinary curl)" ]; then GET_CMD="curl -o"; elif [ -n "$(whereIsBinary wget)" ]; then GET_CMD="wget -O"; else echo "No command curl or wget found, please install yourself."; exit -1 fi $GET_CMD "gradle/wrapper/gradle-wrapper.jar" $WRAPPER_URL $GET_CMD "gradle/wrapper/gradle-wrapper.properties" $WRAPPER_PROPERTIES_URL {code} [~jacques.le.roux], [~soledad] and team, Please feel free to share your thoughts on this updated script. Thanks! > Remove the Gradle wrapper from our release packages and add a step to our > build notes > ------------------------------------------------------------------------------------- > > Key: OFBIZ-10145 > URL: https://issues.apache.org/jira/browse/OFBIZ-10145 > Project: OFBiz > Issue Type: Task > Components: Gradle > Affects Versions: 17.12.01, 16.11.06, 18.12.01 > Reporter: Jacques Le Roux > Assignee: Jacques Le Roux > Priority: Blocker > Fix For: 17.12.01 > > Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh, > init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh, > init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch, > init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch, > init-gradlew-readme.patch > > > Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae, > considering LEGAL-288 and based on a lazy consensus on dev ML, we want to > remove the gradle-wrapper.jar file from the next packaged releases and use > [~jacopoc]'s related proposition to document how to have Gradle working in > the main README.md file. > # Extract the archive file to your local directory. > # Download gradle-wrapper.jar and place it in the > OFBiz-root-dir/gradle/wrapper folder. > I'm not sure if we should recommend a link to download the > gradle-wrapper.jar. This might change in the future (versions, etc.), so > indeed maybe simply asking to download is enough, cf > https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8 > Also we need to add a point about removing gradle-wrapper.jar in > https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz -- This message was sent by Atlassian JIRA (v7.6.3#76005)