[
https://issues.apache.org/jira/browse/OFBIZ-10145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16861003#comment-16861003
]
Jacques Le Roux commented on OFBIZ-10145:
-----------------------------------------
Hi Nicolas,
bq. If we checkout ofbiz-framework and after download the wrapper from own
repos, finally why remove the wrapper ?
Because we don't want to distribute gradle-wrapper.jar. We release the branch,
not the trunk nor the tools. See LEGAL-288 and re-read the description here if
it's not clear enough.
bq. I thinked that the binary would be resolve for a uri published by the
owner.
This is not mandatory. What is required is to not release external binaries.
bq. Demo and buildbot problem need to be not related to ofbiz-framework source
Since they use the release branches and trunk, from where we remove the
external binaries (Gradle was adopted for this reason), we need to get the
gradle-wrapper files from somewhere. Getting them from tools is the less
possible expensible way.
bq. gradle wrapper version need to be present with source code
Yes that's why we have
https://svn.apache.org/repos/asf/ofbiz/tools/Buildbot/Gradle/Wrapper
bq. I fear that we take a hazardous shortcut
There is nothing hazardous with my proposed solution :) And it works!
> Remove the Gradle wrapper from our release packages and add a step to our
> build notes
> -------------------------------------------------------------------------------------
>
> Key: OFBIZ-10145
> URL: https://issues.apache.org/jira/browse/OFBIZ-10145
> Project: OFBiz
> Issue Type: Task
> Components: Gradle
> Affects Versions: 17.12.01, 16.11.06, 18.12.01
> Reporter: Jacques Le Roux
> Assignee: Jacques Le Roux
> Priority: Blocker
> Fix For: 17.12.01
>
> Attachments: OFBIZ-10145-gradlew.patch, init-gradle-wrapper-R16.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper-trunk-and-18.sh, init-gradle-wrapper-trunk-and-18.sh,
> init-gradle-wrapper.ps1, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradle-wrapper.sh, init-gradle-wrapper.sh, init-gradle-wrapper.sh,
> init-gradlew-readme-R16.patch, init-gradlew-readme-R17.1.patch,
> init-gradlew-readme-R17.1.patch, init-gradlew-readme.patch,
> init-gradlew-readme.patch
>
>
> Following the discussion at http://markmail.org/message/nd7grfiyobjkfwae,
> considering LEGAL-288 and based on a lazy consensus on dev ML, we want to
> remove the gradle-wrapper.jar file from the next packaged releases and use
> [~jacopoc]'s related proposition to document how to have Gradle working in
> the main README.md file.
> # Extract the archive file to your local directory.
> # Download gradle-wrapper.jar and place it in the
> OFBiz-root-dir/gradle/wrapper folder.
> I'm not sure if we should recommend a link to download the
> gradle-wrapper.jar. This might change in the future (versions, etc.), so
> indeed maybe simply asking to download is enough, cf
> https://www.google.com/search?q=gradle-wrapper.jar+download&ie=UTF-8
> Also we need to add a point about removing gradle-wrapper.jar in
> https://cwiki.apache.org/confluence/display/OFBIZ/Release+Management+Guide+for+OFBiz
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
