[ 
https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16874815#comment-16874815
 ] 

Jacques Le Roux edited comment on OFBIZ-10150 at 6/28/19 11:07 AM:
-------------------------------------------------------------------

Thanks Rohit, 

Your patch is in
trunk r1862271
R18 r1862272
R17 r1862273
R16 r1862274

I don't close as it's an opportunity to fix all case. We could create sub-tasks 
but I believe patches and comments here are enough. No needs to dilute things.

Thankd Jesse for report.


was (Author: jacques.le.roux):
Thanks Rohit, 

Your patch is in
trunk r1862271
R18 r1862272
R17 r1862273
R196 r1862274

I don't close as it's an opportunity to fix all case. We could create sub-tasks 
but I believe patches and comments here are enough. No needs to dilute things.

Thankd Jesse for report.

> supplierProductId Should Have Consistent Types Across Entities.
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-10150
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10150
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order, product
>    Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>         Environment: all
>            Reporter: jesse thomas
>            Assignee: Jacques Le Roux
>            Priority: Major
>         Attachments: OFBIZ-10150.patch
>
>
> During some data migration I hit an issue where my data for supplierProductId 
> was too long. So I looked up the fields and noticed that the order item 
> entity had a different type for the field than the supplier product entity. I 
> think it would be a good idea to pick one so the two fields can be treated 
> consistently. I would vote for id-long, but I think either way it would be 
> good to have them be the same type. There are other fields that have this 
> issue too if you are interested?
>   
> Thanks!
> applications/datamodel/entitydef/order-entitymodel.xml:      
> <entity entity-name="OrderItem".......
> <field name="supplierProductId" type="id-long"></field>
> applications/datamodel/entitydef/product-entitymodel.xml:      
> <entity entity-name="SupplierProduct"......
> <field name="supplierProductId" type="id"></field>



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to