[ 
https://issues.apache.org/jira/browse/OFBIZ-11955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190699#comment-17190699
 ] 

Jacques Le Roux commented on OFBIZ-11955:
-----------------------------------------

Sorry again Alex, the patch does not completely apply:
{noformat}
C:\projectsASF\Git\ofbiz-framework>git status
On branch trunk
Your branch is up to date with 'origin/trunk'.

C:\projectsASF\Git\ofbiz-framework>git apply variantinfojs-final.patch
variantinfojs-final.patch:367: trailing whitespace.
          });
variantinfojs-final.patch:443: trailing whitespace.

variantinfojs-final.patch:479: trailing whitespace.
          });
error: patch failed: 
applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy:102
error: 
applications/order/groovyScripts/entry/catalog/InlineProductDetail.groovy: 
patch does not apply
error: patch failed: 
applications/order/groovyScripts/entry/catalog/ProductDetail.groovy:106
error: applications/order/groovyScripts/entry/catalog/ProductDetail.groovy: 
patch does not apply
error: patch failed: 
applications/order/groovyScripts/entry/catalog/ProductSummary.groovy:97
error: applications/order/groovyScripts/entry/catalog/ProductSummary.groovy: 
patch does not apply
error: patch failed: 
applications/order/template/entry/catalog/ProductDetail.ftl:265
error: applications/order/template/entry/catalog/ProductDetail.ftl: patch does 
not apply
error: patch failed: 
applications/order/template/entry/catalog/ProductSummary.ftl:49
error: applications/order/template/entry/catalog/ProductSummary.ftl: patch does 
not apply
error: patch failed: 
applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl:17
error: applications/order/template/entry/catalog/ProductUomDropDownOnly.ftl: 
patch does not apply
error: applications/order/template/entry/catalog/ProductVariantJS.ftl: already 
exists in working directory
{noformat}

> display/selection of unit of measure is broken
> ----------------------------------------------
>
>                 Key: OFBIZ-11955
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11955
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ecommerce, order
>    Affects Versions: Release Branch 17.12, Trunk
>            Reporter: Alex Bodnaru
>            Priority: Major
>         Attachments: Image 002.png, Image 002.png, Image damned.png, 
> Image1.png, ProductVariantJS.ftl, image-2020-08-22-13-00-44-947.png, 
> image-2020-08-22-13-00-57-856.png, image-2020-08-22-13-03-22-775.png, 
> image-2020-08-22-13-04-07-722.png, variantinfojs-1.patch, 
> variantinfojs-2.patch, variantinfojs-3.patch, variantinfojs-data.xml, 
> variantinfojs-final.patch
>
>
> checkAmtReq and getVariantPrice are broken for similar reasons, too.
> the display and selection of alternative uom elements occur in multiple 
> forms, one for each product: whether detailed or in summary. thus, they 
> should be marked by names and classes, not by ids, that are unique in the 
> entire document.
> the bug did not manifest in demo data, since only one product has alternative 
> packaging.
> i did duplicate wg-1111* products and arranged their relations. is, btw, a 
> way to export product trees in order to share them?
> the fix does span the framework and ecommerce repositories.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to