[
https://issues.apache.org/jira/browse/OFBIZ-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441175#comment-17441175
]
Michael Brohl commented on OFBIZ-12371:
---------------------------------------
Can you explain what goes wrong there in your opinion? What do you expect?
A common logic with roles is to implicitely create the needed role using the
ensurePartyRole service. I think the currently implemented business logic takes
any party and ensures the needed role.
If the expectation would be that only parties already having this role can be
selected, this would be a change of the business logic. Without
ensurePartyRole, you would also first have to assign the role to the party and
then create the BudgetRole in this case. I don't think this is a convenient
approach. Users can change this behaviour in their custom projects any time.
I think this is the same for all other Jiras you have created recently.
> BudgetRole: improbable selection possible, PartyRole gets created
> -----------------------------------------------------------------
>
> Key: OFBIZ-12371
> URL: https://issues.apache.org/jira/browse/OFBIZ-12371
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: Trunk, 18.12.01
> Reporter: Pierre Smits
> Priority: Major
> Labels: roles
>
> On the BudgetRole page (see
> [https://demo-stable.ofbiz.apache.org/accounting/control/BudgetRoles?budgetId=DemoBudget001)]
> an improbable combination of Party and Role can be set and submitted.
> Leading to PartyRole record being created.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
