[
https://issues.apache.org/jira/browse/OFBIZ-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441233#comment-17441233
]
Pierre Smits commented on OFBIZ-12371:
--------------------------------------
In addition to the 'fool me... ' in relation to the ensurePartyRole service,
suppose we brush this off as: what is the harm (apart from the removal of
undesirable PartyRole records in part)?
Suppose in some other <object>Role screen there is indeed a tighter process to
select the party in a particular role for that object (but doesn't invoke
ensurePartyRole). Now, the user there can select the improbable party-role
combination and persist that as the <object>Role record. And the PartyRole
record can't be deleted (referential integrity). And the underlying activity
(consider picking/packing) won't get done in time. And clean-up there must take
place there too. Otherwise it could/would happen again.
> BudgetRole: improbable selection possible, PartyRole gets created
> -----------------------------------------------------------------
>
> Key: OFBIZ-12371
> URL: https://issues.apache.org/jira/browse/OFBIZ-12371
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: Trunk, 18.12.01
> Reporter: Pierre Smits
> Assignee: Pierre Smits
> Priority: Major
> Labels: roles
>
> On the BudgetRole page (see
> [https://demo-stable.ofbiz.apache.org/accounting/control/BudgetRoles?budgetId=DemoBudget001)]
> an improbable combination of Party and Role can be set and submitted.
> Leading to PartyRole record being created.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
