[
https://issues.apache.org/jira/browse/OFBIZ-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17441262#comment-17441262
]
Pierre Smits commented on OFBIZ-12364:
--------------------------------------
Hi there,
There are multiple examples in the demo dataset where some fields of an entity
are not set. Though it would be nice to have all fields of all demo record
definitions (an we will get there, time and a contributor willing), it is no
deal breaker.
Getting back to the subject as per the title (EmplPositionType): it is not a
problem that the description field would be the same as the title field. We all
know that such EmplPositionType is hard to describe. :D
Yes, OFBIZ-12021 was resolved. But got reverted, because of some testing
issues. Which didn't get registered here in Jira as separate issues. And given
the priority of that ticket being 'Minor' it got brushed aside. I have
corrected that aspect today on the ticket (raising it to priority 'Major').
Hopefully it attracts the attention of a contributor soon.
Re: GitHub, etc.
Yes, the project does work with pull requests via GitHub. It is the preferred
way. You can just:
Clone in the web interface of Github from
[https://github.com/apache/ofbiz-frame] (to have your public repo visible from
where you can push Pull Requests to the projects repo.
Also, Git allows for having more than one remote to your local clone.
You can just add [https://github.com/apache/ofbiz-framework.git] as a remote
there. And create pull requests directly to the project's repo from there.
The same goes, of course, for [https://github.com/apache/ofbiz-plugins.git.]
There is plenty of documentation on the interwebs that explains such.
> Incorrect definition and usage of EmplPositionType?
> ---------------------------------------------------
>
> Key: OFBIZ-12364
> URL: https://issues.apache.org/jira/browse/OFBIZ-12364
> Project: OFBiz
> Issue Type: Improvement
> Components: humanres
> Affects Versions: Trunk
> Reporter: ddev
> Priority: Major
> Attachments: ofbiz-empl-position-type-patch.diff
>
>
> In the Data Model Resouce Book, on page 326 (or on page 306, depending on how
> you are counting pages), it shows EmplPositionType having fields "title" for
> the position title, and "description" to describe what the position is
> supposed to be about.
> However, EmplPositionType in ofbiz is missing the "title" field.
> Fixing this is a simple one line patch.
> However, additionally ofbiz seed data seems to put the title data in the
> description field, like so:
> applications/datamodel/data/seed/HumanResSeedData.xml: <EmplPositionType
> description="Chief Executive Officer" hasTable="N" emplPositionTypeId="CEO"/>
> This is a simple patch as well (patch is attached)
> But does this mean we would assume that people are putting the title in the
> description field in their local database, meaning we wouldn't patch it
> without some kind of translation system to move the description data to the
> title field. What about those people who are using the field correctly
> already?
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
