danwatford commented on a change in pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#discussion_r789783148
##########
File path: applications/humanres/widget/forms/RecruitmentForms.xml
##########
@@ -427,14 +425,14 @@ under the License.
<field-map field-name="viewSize" from-field="viewSize"/>
</service>
</actions>
- <field name="partyId" title="Employee Name">
+ <field name="partyId" title="${UiLabelMap.CommonParty}">
<display-entity entity-name="PartyNameView"
description="${firstName} ${middleName} ${lastName} ${groupName}">
<sub-hyperlink target="/partymgr/control/viewprofile"
target-type="inter-app" description="${partyId}" link-style="buttontext">
<parameter param-name="partyId" from-field="partyId"/>
</sub-hyperlink>
</display-entity>
</field>
- <field name="emplPositionId"
title="${uiLabelMap.HumanResEmployeePositionId}" widget-style="linktext">
+ <field name="emplPositionId" title="${uiLabelMap.CommonPosition"
widget-style="linktext">
Review comment:
Missing closing brace following CommonPosition.
##########
File path: applications/humanres/widget/RecruitmentScreens.xml
##########
@@ -302,7 +302,7 @@ under the License.
<include-form name="FindRelocation"
location="component://humanres/widget/forms/RecruitmentForms.xml"/>
</decorator-section>
<decorator-section name="search-results">
- <include-form name="ListRelocation"
location="component://humanres/widget/forms/RecruitmentForms.xml"/>
+ <include-grid name="ListRelocation"
location="component://humanres/widget/forms/RecruitmentForms.xml"/>
Review comment:
With this PR applied, the column header for search results on screen
https://localhost:8443/humanres/control/FindRelocation is displayed as
`${UILABELMAP.COMMONPOSITION`.
On trunk it is displayed as `EMPLOYEE NAME`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
