PierreSmits commented on pull request #466:
URL: https://github.com/apache/ofbiz-framework/pull/466#issuecomment-1023246619
Hi @danwatford ,
As you can see from line item 429 the display entity for the field also show
${groupName}, meaning that also party groups may be referenced. Thus having
CommonParty is a valid choice for the title. But more importantly the existing
title of the field is **hard-coded**, not an existing label. So that is wrong.
Additionally when data is available in the appropriate records, the value
shown is a combination of **name** and **id** of the party.
Hence also warranting an improvement. We also have to keep in mind that it
is totally acceptable that external people through subcontracting can be in an
employee position and a falling in a reporting structure.
As to change on line item 435, as a value a positionId is shown, but it is
by implication a position. A generic label for position (as it also can be
used with lat and long, locations in warehouses etc) would make sense.
That Michael believes that hard coded titles or even field specific labels
are good enough for the project, is his prerogative. He may think and believe
so.
But that does **NOT** imply that he can dictate to other contributors to
throw out common sense and to do as he tells (as a suggestion, of course) and
not apply that common sense to make OFBiz a better product.
The application of a common label has been around since day one of the
project, and has been applied across all applications to be able to reduce the
load on system, contributor, developer and network. If fields are used in forms
across application then a common label is warranted to be preferred over a
component specific, eg CommonProduct in grids and lookup fields, instead of
productId.
Do a search/find in the labels for <property*productId", and you'll see I
have a point (for improvement). And there are plenty more of such examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
