[
https://issues.apache.org/jira/browse/OFBIZ-12688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-12688:
------------------------------------
Description:
This refer to a comment I made in OFBIZ-7112: https://s.apache.org/ivrq6
The crux being:
{quote}
It's a long time now we have the SystemProperty entity[...]
When we discussed about it before the implementation, it was clear that only
business (ie not system) properties should be concerned. To be clear, for me
the system properties are the properties in files at
framework/start/src/main/resources/org/apache/ofbiz/base/start/ and some other
files like freemarkerTransforms.properties, fop.properties,
catalina.properties, debug.properties, owasp.properties, security.properties,
requestHandler.properties, url.properties and maybe some others I missed
# So the 1st flaw was to name this entity SystemProperty. It should have been
named BusinessProperty. We could consider rename it, but that's minor in
comparison with the second flaw
# The second flaw is that we kept the business properties files. To avoid
duplication and confusion all the business properties should be in the database
and a specific UI should be created to easier handled them.
TL;DR: We will not resolve the SystemProperties issues w/o no longer using
properties files but for the system properties. Of course then renaming the
SystemProperty entity to BusinessProperty is necessary. Having a specific UI
for DB access for these properties is also necessary. I foresee the webtools as
the best place for this UI. It should be accessible by tenants.
{quote}
This issue concents only the 1st point
was:
This refer to a comment I made in OFBIZ-7112: https://s.apache.org/ivrq6
The crux being:
{quote}
It's a long time now we have the SystemProperty entity[...]
When we discussed about it before the implementation, it was clear that only
business (ie not system) properties should be concerned. To be clear, for me
the system properties are the properties in files at
framework/start/src/main/resources/org/apache/ofbiz/base/start/ and some other
files like freemarkerTransforms.properties, fop.properties,
catalina.properties, debug.properties, owasp.properties, security.properties,
requestHandler.properties, url.properties and maybe some others I missed
# So the 1st flaw was to name this entity SystemProperty. It should have been
named BusinessProperty. We could consider rename it, but that's minor in
comparison with the second flaw
# The second flaw is that we kept the business properties files. To avoid
duplication and confusion all the business properties should be in the database
and a specific UI should be created to easier handled them.
{quote}
This issue concents only the 1st point
> Change SystemProperty entity name to BusinessProperty
> -----------------------------------------------------
>
> Key: OFBIZ-12688
> URL: https://issues.apache.org/jira/browse/OFBIZ-12688
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: Upcoming Branch
> Reporter: Jacques Le Roux
> Priority: Minor
>
> This refer to a comment I made in OFBIZ-7112: https://s.apache.org/ivrq6
> The crux being:
> {quote}
> It's a long time now we have the SystemProperty entity[...]
> When we discussed about it before the implementation, it was clear that only
> business (ie not system) properties should be concerned. To be clear, for me
> the system properties are the properties in files at
> framework/start/src/main/resources/org/apache/ofbiz/base/start/ and some
> other files like freemarkerTransforms.properties, fop.properties,
> catalina.properties, debug.properties, owasp.properties, security.properties,
> requestHandler.properties, url.properties and maybe some others I missed
> # So the 1st flaw was to name this entity SystemProperty. It should have been
> named BusinessProperty. We could consider rename it, but that's minor in
> comparison with the second flaw
> # The second flaw is that we kept the business properties files. To avoid
> duplication and confusion all the business properties should be in the
> database and a specific UI should be created to easier handled them.
> TL;DR: We will not resolve the SystemProperties issues w/o no longer using
> properties files but for the system properties. Of course then renaming the
> SystemProperty entity to BusinessProperty is necessary. Having a specific UI
> for DB access for these properties is also necessary. I foresee the webtools
> as the best place for this UI. It should be accessible by tenants.
> {quote}
> This issue concents only the 1st point
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
