danwatford commented on PR #547: URL: https://github.com/apache/ofbiz-framework/pull/547#issuecomment-1270070215
> @danwatford reagrding your last comment (adding my tests in `RenderableFtlFormElementsBuilderTest`), it seems that it would take some rewriting, I would have expected that `makeHyperlinkString` would take a `ModelFormField.HyperLinkField`, but it takes a `ModelFormField.SubHyperlink` instead, so I'm not sure how I could test it. Is it an actual error? Hi @florianMo , It could well be an error, but might also just be an oversight. I found the hyperlink code quite difficult to follow and hoped it would become easier to deal with once the more refactoring was complete with ModelFormRenderer. The good thing is that your work prompted me to take another look at how links are represented so I feel I have a better handle on them now. There are also a few deprecations, dated back at least to 2016, related to hyperlink attributes in the .xsd files so we might find removing those simplifies things. **I withdraw my request that you add tests `RenderableFtlFormElementsBuilderTest`** as I am happy you have encoded rules around the title attribute in MacroFormRendererTest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
