danwatford commented on PR #547: URL: https://github.com/apache/ofbiz-framework/pull/547#issuecomment-1270422561
Tested by observing how changes to form definitions affect displayed items. Using default data. Page: https://localhost:8443/partymgr/control/showclassgroups The form on this page is defined by party/widget/partymgr/PartyClassificationForms.xml#ListPartyClassificationGroups ### Field: partyClassificationGroupId Changes to the title, description and size attributes of the hyperlink element were all reflected as expected in the browser. ### Field: deleteLink **Attribute `size` does not affect rendering of this hyperlink, meaning the description is not truncated.** When not considering the `size` attribute, the `title` attribute works as expected. #### Cause The cause of the discrepancy between the two renderings of hyperlink fields was tracked down the deleteLink being rendered as a hidden form. When rendering these forms, the anchor tag is created in WidgetWorker's `makeHiddenFormLinkAnchorElement` method. We therefore need the logic for rendering the anchor's title attribute based on the description, size and title attributes of the hyperlink field, similar to that used in MacroFormRenderer's `makeHyperlinkString` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
