florianMo commented on code in PR #548:
URL: https://github.com/apache/ofbiz-framework/pull/548#discussion_r990044205
##########
framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/RenderableFtlFormElementsBuilder.java:
##########
@@ -287,7 +287,7 @@ public RenderableFtl textField(final Map<String, Object>
context, final ModelFor
.stringParameter("id", id)
.stringParameter("event", event != null ? event : "")
.stringParameter("action", action != null ? action : "")
- .booleanParameter("disabled", disabled)
+ .stringParameter("disabled", String.valueOf(disabled))
Review Comment:
I'll switch to a `boolean` in `HtmlFormMacroLibrary.ftl`, it's a little bit
cleaner indeed, so this change is no longer needed (vs comparing a `string` to
`true` in the macros).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
