florianMo commented on code in PR #548:
URL: https://github.com/apache/ofbiz-framework/pull/548#discussion_r990084738


##########
framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormFieldBuilder.java:
##########
@@ -729,7 +729,7 @@ public String getConditionGroup() {
      * Gets disabled.*
      * @return the disabled
      */
-    public boolean getDisabled() {
+    public FlexibleStringExpander getDisabled() {

Review Comment:
   > A few changes requested around exposing disabled boolean state vs the 
specification of the disabled field attribute. These changes might have 
knock-on effects to callers which would also need clean up.
   
   Changes made @danwatford, so now we're passing a boolean to HTML macros 
(most notable adjustment).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to