javier-ochoa commented on code in PR #919:
URL: https://github.com/apache/ofbiz-framework/pull/919#discussion_r2530070639
##########
docker/docker-entrypoint.sh:
##########
@@ -146,7 +146,7 @@ ofbiz_setup_env() {
OFBIZ_POSTGRES_TENANT_USER=${OFBIZ_POSTGRES_TENANT_USER:-ofbiztenant}
OFBIZ_POSTGRES_TENANT_PASSWORD=${OFBIZ_POSTGRES_TENANT_PASSWORD:-ofbiztenant}
-
OFBIZ_DISABLE_COMPONENTS=${OFBIZ_DISABLE_COMPONENTS-plugins/birt/ofbiz-component.xml}
+
OFBIZ_DISABLE_COMPONENTS=${OFBIZ_DISABLE_COMPONENTS:-plugins/birt/ofbiz-component.xml}
Review Comment:
hello @danwatford. Perhaps I made a mistake since sh scripts are not my
strength, but i wonder what is the difference. As far as I know, the original
expression would use default value only if the variable was not set. If the
variable was set, and empty, then it would use empty, which can be argued if it
is ok or not. Adding double-dots, if I am not wrong, the variable must be set
and be different than empty, or else, the default value would be used.
So the diff is if the default value should be used when variable is set but
empty (OFBIZ_DISABLE_COMPONENTS="")
Nevertheless, if it should be without the dots, personally i dont have any
issue with the rollback of the change.
Cheers!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
