danwatford commented on code in PR #919:
URL: https://github.com/apache/ofbiz-framework/pull/919#discussion_r2544750872
##########
docker/docker-entrypoint.sh:
##########
@@ -146,7 +146,7 @@ ofbiz_setup_env() {
OFBIZ_POSTGRES_TENANT_USER=${OFBIZ_POSTGRES_TENANT_USER:-ofbiztenant}
OFBIZ_POSTGRES_TENANT_PASSWORD=${OFBIZ_POSTGRES_TENANT_PASSWORD:-ofbiztenant}
-
OFBIZ_DISABLE_COMPONENTS=${OFBIZ_DISABLE_COMPONENTS-plugins/birt/ofbiz-component.xml}
+
OFBIZ_DISABLE_COMPONENTS=${OFBIZ_DISABLE_COMPONENTS:-plugins/birt/ofbiz-component.xml}
Review Comment:
Hi @javier-ochoa -
> As far as I know, the original expression would use default value only if
the variable was not set. If the variable was set, and empty, then it would use
empty, which can be argued if it is ok or not.
With the change in this PR, how do we handle the case where the user wants
to enable the birt plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
