mdedetrich commented on code in PR #52:
URL: https://github.com/apache/incubator-pekko/pull/52#discussion_r1024273803
##########
.asf.yaml:
##########
@@ -28,7 +28,21 @@ github:
rebase: true
protected_branches:
- main: { }
+ main:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Scalafmt
+
+ required_pull_request_reviews:
+ dismiss_stale_reviews: false
+ require_code_owner_reviews: false
+ required_approving_review_count: 1
Review Comment:
So this is an interesting point. Historically akka always required 2
approvals, even for trivial changes. I will say however in terms of
practicality especially right now with a lot of mechanical and trivial changes
needed to get the project bootstrapped, going with 1 should be fine.
We can revisit this process later, I personally think that requiring 2
reviewers once the project is setup has merit especially since at that point in
time we will also start seeing non trivial functional changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
