mdedetrich commented on code in PR #52:
URL: https://github.com/apache/incubator-pekko/pull/52#discussion_r1025264800
##########
.asf.yaml:
##########
@@ -28,7 +28,21 @@ github:
rebase: true
protected_branches:
- main: { }
+ main:
+ required_status_checks:
+ # strict means "Require branches to be up to date before merging".
+ strict: false
+ # contexts are the names of checks that must pass
+ contexts:
+ - Scalafmt
+
+ required_pull_request_reviews:
+ dismiss_stale_reviews: false
+ require_code_owner_reviews: false
+ required_approving_review_count: 1
Review Comment:
> Any review that has open requests or discussion blocks the merge. (only
merge when consensus is reached).
To me I think this is too strict, I have been in cases where pull requests
stuck open in perpetuity because someone forgets to click the "resolve" button.
Either that or committers will just blindly hit resolve which at that point
defeats the purpose of it.
Should we discuss in the mailing list? I think for now this is fine, we can
always add stricter checks later if there is a consensus on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@pekko.apache.org
For additional commands, e-mail: notifications-h...@pekko.apache.org
